As Dreekenkorin said it, it all depends on your class, but also what you will be doing in the game. Are you on a pvp or pve realm, do you enjoy battlegrounds, are you looking for end game items to make.
Warrior – I would certainly recommend Blacksmithing, both weaponsmithing & Armorsmithing will be great for a warrior.
Paladin – You can go blacksmithing, but a lot of people will not recommend you to go into Armorsmithing, for there is not a lot of plate armor geared towards a Paladin.
If you went engineering as a Paladin then you would know have access to ranged weapons i.e. Bombs, dynamite. (not great damage, but could be used to pull)
If you are doing a lot of Bg’s or on a PVP realm then Engineering will be very beneficial due to the trinkets that you will be able to make, along with the new end game epic gears are amazing. It is also been said to be one of the more enjoyable professions.
Good Luck on your quest,
Regards,
Jhua