ProfessionsFollow

Leatherworking offers the best stat gain, but you won't get much out of it besides those and the drums. There aren't any recipes you'd want. With it you can get 102 Stamina or 130 AP. I should note, though, that you lose a bracer enchant, which can be 40 Stamina, 50 AP, 15 Expertise Rating, 6 to all stats or 15 Defense Rating.

JC is a great DpS and Tanking profession. With it, you'll get 3 jewelers gems, each of which offer 21 Stamina or 14 strength over the best quality gems. You have the added bonus of being able to cut all of your other gems, which is awesome. And you may find yourself upgrading certain gems that you wouldn't have had the highest quality for anyway.

Following that, Blacksmithing will be best. It offers an extra 40 Strength or 60 Stamina by adding two additional sockets to your gear.

Enchanting is next, as two ring enchants will give you 80 AP or 60 health.

Alchemy may be next, as it will give you a 64 AP boost, or 650 additional health, but ONLY while you are using a FLASK. Mixology will boost other elixirs, though, until you get to the point where you are using the best items.

Inscription is good, too. Your shoulder enchants can give you 120 AP and 15 crit (Hodir gives 40 AP and 15 crit) or 60 dodge and 15 Defense Rating (Hodir gives 20 dodge and 15 Defense). It is far from being the best, stat-wise. But, Inscription offers a LOT of utility. If you aren't willing to have an alt level it, I'd advise it for your main.

Engineering is... worthless. There's nothing good for DK tanks, and the only reward for DpS is minimal.

You won't be getting anything interesting out of tailoring.

Mining will give you 60 Stamina.

Skinning will give you 40 crit.

Herbalism will give you a HoT.

If you want to just Min/Max, Leatherworking is best now for tanks, but not by much. If you want to DpS, JC is best (especially if your spec has +% strength talents).

I'd advise going JC, regardless of if you are leaning more towards tanking or DpS. The utility is awesome, and you can get a good trinket for when first gearing. You'll lose a few Stamina, but the ability to make all your own gems is great.

[EDIT]

As for your build, it's fine, but I highly advise moving the 2 points from On a Pale Horse and the 2 from Improved Unholy Presence to Dark Conviction. At least do the OaPH points. There are arguments for why it's good to keep Imp. UP though.

And, for your tank spec, get rid of Chillblains for Two-Handed Specialization or 2 into Bladed Armor, unless you always run with a Mage and need to keep up Torment the Weak. You also don't need 3/3 Scent of Blood until you have high avoidance. I'm running 2/3 right now, with 35.8% unbuffed, and I only ever need more RP if I spammed FS because everything else was on CD and a DpS was somehow about to pass me on a boss.

Also, if you are using Unholy, you should be using this sigil until you can get this one, which is only NINETEEN emblems of conquest, so you can probably get it in 2-3 hours of groups, MAX. Death Coil should be one of your hardest hitting attacks.

Other than those small things, your build looks good.

Edited, Nov 25th 2009 10:26am by idiggory