Well, gathering professions are always a good start (some include enchanting as a gathering profession since you can farm greens and "gather" enchanting items).
For Shamans, a few professions have nice items for high level shamans. Engineering has a set of goggles at 350 engineering (one for each spec). Generally rogues and hunters will get more use out of engineering than others because they can be the only ones to live in a fight, and then use jumper cables to res a healer if no soulstone. Leatherworking is also good because I know they have some great mail items for shamans too... and then obviously blacksmithing for either weapons or armor.
Leatherworking is "best" paired with skinning since you'll get to use all that you skin. Engineering and Blacksmithing go well with mining (for the same reasons).
Enchanting is also a great craft. They have a few high level enchants they can only do on themselves such as some of the ring enchants and you'll always be slightly more pimped than your average player since you'll always be self-enchanting. It also is great for quest items you can't use.
Alchemy/herbalism aren't bad because you can make your own potions, but for me... my guild has A LOT of alchemists. We have more potions than we know what to do with, so.... yeah. haha Everyone gets about equal use out of alchemy.
The only craft that would be fairly useless for a shaman is tailoring. You won't get almost any use out of the items you can make.
PS: I forgot engineering is almost worth is JUST for parachute cloak. LOL I wear it all the time at 70 when I am on my flying mount doing quests. You never know when some crazy mage will drop, instant cast something to knock you off... and then slow fall. Having your own cloak to slow fall will save your life a decent amount. It's a gold sink though.
PSS: At least on my server, all the gathering professions end up about the same profit. Skinners make up for lower "cost" for their items with volume. A lot of what you kill will be skinnable, whereas herbalists and miners have to hunt for their spawns.
Edited, Dec 11th 2007 12:00am by Jiade