I picked a Night Elf because it was my first character and I was a noob. Seriously, more than 3/4 of all rogues are either NE or UD. If I were to do it all over again, I would be a Dwarf.
race hardly matters, but undead gives the greatest benfits by far, but even that is only slightly noticeable from my encounters...nothing makes up for not knowing your combos and class
i like the BE rogues becuase of the racials are awesome for PVP but if you want a good PVE race then go for Undead or Orc or for Alliance go for human or NE or Gnome to **** the horde off